fix(platform-server): wait for async app initializers to complete before removing server side styles #16712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxhub
reviewed
May 15, 2017
| for (let i = 0; i < appInits.length; i++) { | ||
| const initResult = appInits[i](); | ||
|
|
||
| const that = this; |
alxhub
reviewed
May 15, 2017
| Array.prototype.slice.apply(dom.querySelectorAll(document, `style[ng-transition]`)); | ||
| styles.filter(el => dom.getAttribute(el, 'ng-transition') === transitionId) | ||
| .forEach(el => dom.remove(el)); | ||
| export function bootstrapListenerFactory(transitionId: string, document: any, injector: Injector) { |
alxhub
approved these changes
May 15, 2017
IgorMinar
approved these changes
May 15, 2017
…ore removing server side styles This fixes a flicker when transitioning from server rendered page to client rendered page in lazy loaded routes by waiting for the lazy loaded route to finish loading, assuming initialNavigation on the route is set to 'enabled'. Fixes #15716
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
…ore removing server side styles (angular#16712) This fixes a flicker when transitioning from server rendered page to client rendered page in lazy loaded routes by waiting for the lazy loaded route to finish loading, assuming initialNavigation on the route is set to 'enabled'. Fixes angular#15716
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
…ore removing server side styles (angular#16712) This fixes a flicker when transitioning from server rendered page to client rendered page in lazy loaded routes by waiting for the lazy loaded route to finish loading, assuming initialNavigation on the route is set to 'enabled'. Fixes angular#15716
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a flicker when transitioning from server rendered page to client rendered page in lazy loaded routes by waiting for the lazy loaded route to finish loading, assuming initialNavigation on the route is set to 'enabled'.
Fixes #15716
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
There is a flicker when transitioning from server side rendered page to lazy loaded routes, even when initialNavigation is set to 'enabled'
What is the new behavior?
There is no flicker. Server side styles are removed only after the lazy loaded route has finished loading.
Does this PR introduce a breaking change? (check one with "x")